Update google-auth-library (and others) #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| oauthStub.restore(); | ||
| }); | ||
|
|
||
| it('should at least consider running', async() => { |
There was a problem hiding this comment.
Suggested change
| it('should at least consider running', async() => { | |
| it('should at least consider running', () => { |
There was a problem hiding this comment.
This seems to work on my end but I'm not totally sure about it..
|
Hey @csb324. Thank you for the PR 👍 Do you think we can have failing CI fixed? I'll be more than happy to mere your fix :) |
|
Hi. I left a comment on the PR. Was you able to write to a google-sheet @csb324 ? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #228!
It looked like google-auth-library was about five major versions behind, and google had made some changes to how it all worked. So I...
And now the package is working for me again! The one thing I couldn't solve is that the linter doesn't like my async arrow function test, so I imagine the CI tests here will fail. I couldn't figure out what that was about, considering the tests work, and the google-oauth test suite uses the same syntax without complaining.