Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider chalk #159

Open
denar90 opened this issue Mar 10, 2018 · 6 comments
Open

Consider chalk #159

denar90 opened this issue Mar 10, 2018 · 6 comments

Comments

@denar90
Copy link
Collaborator

denar90 commented Mar 10, 2018

We are using our own stuff for coloring console output, maybe we should also think about https://github.com/chalk/chalk

wdyt?

@paulirish
Copy link
Owner

Works for me

@pedro93
Copy link
Collaborator

pedro93 commented Mar 10, 2018

Is there any advantage to using chalk?

@denar90
Copy link
Collaborator Author

denar90 commented Mar 12, 2018

Just for tuning our code and have ability to use colored output with better API

@pedro93
Copy link
Collaborator

pedro93 commented Mar 24, 2018

What about wunderbar? @gribnoysup already submitted a PR #161 and it looks quite nice. Given that this issue was to consider chalk for code clean up and enabled colored output I think we have a nice alternative.

@denar90
Copy link
Collaborator Author

denar90 commented Mar 24, 2018

cc @paulirish

@gribnoysup
Copy link
Contributor

@pedro93 @denar90 as my PR was mentioned, I decided that I'll add my two cents to the discussion 😸

Wunderbar could replace your forked chart drawing library cli-charts. But in your codebase, I see that these colorify functions are used mainly for logging, and not for charts (currently in the forked cli-charts implementation charm library is responsible for coloring chart bars). So considering chalk seems like a topic not connected directly to Wunderbar.

That said, If you decide to go with Wunderbar, switching your custom colorify functions to chalk makes a lot of sense. Wunderbar uses chalk and that means that chalk will already be in your bundle, so why not use it? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants