-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Report metrics to Graphite/ Cloudwatch/ etc #153
Comments
We were thinking about multiple providers here - https://github.com/paulirish/pwmetrics/blob/master/lib/sheets/index.ts#L13-L15. I think others would not mind having a few more providers :) @vinhlh are you interested working on it? |
Sure, let me give a try |
@vinhlh hi, did you have the ability to prototype the solution? |
Hey, sorry, I was so busy, will give a try soon |
Nice 👍 Will be really good to have other options for submitting results :) |
While it's a good idea, it couples pwmetrics with external services. Does not sound good, does it? Mainly, I refer to feature creep and coupling. For example, pwmetrics can be used with AppInsights as a buffer for data. Wrapped a docker container, a custom entrypoint with bash/powershell which runs pwmetrics passing command arguments, and then invokes a tiny script to post-process data and push to AppInsights. Other way around - two containers; one runs pwmetrics, second grabs the output and pushed to data storage. It's 50-lines powershell script. Similar approach can be used for other services, AWS and others. adapters as smaller, independent scripts or containers. Now, let's think about other tooling, Lighthouse, and many others. Most of them produce machine-readable data; json, csv or xml. Should we ask every single tool to support AWS CloudWatch, Azure, Graphite and many other data storage? - not sure. Again, only 2cents. Intention is great, and it is totally up to the team to consider this implementation. |
Similar to uploading Lighthouse traces, we could report metrics to Monitoring services like Graphite, Cloudwatch, etc.
What do you guys think?
This looks similar to
submit
option, we could support multiple providers: 'gsheet', 'graphite', etc, right?The text was updated successfully, but these errors were encountered: