Multi-Word last name or first name

[javb99]

A slack name with more than two words will not match to the user in Planning Center. This seems to be due to a split on spaces where element 0 is treated as the first name and element 1 is treated as the last name.

[pastorhudson]

Is this in reference to the app permissions lookup?

[javb99]

Yes.

[pastorhudson]

Ok I need a bit more info. Can we assume that if there is a 3rd element then it's First, Middle, and Last name?

fl_name = {'first_name': message.sender['source']['real_name'].split()[0],
                       'middle_name': message.sender['source']['real_name'].split()[1],
                       'last_name': message.sender['source']['real_name'].split()[2]}

Or is there some sort of double last name edge case we're dealing with?

[javb99]

It is a double last name case. For example: "Joseph Van Boxtel" should split to (First: "Joseph" Last: "Van Boxtel") The following seems to work.
fl_name = {'search_name_or_email': message.sender['source']['real_name']}
Do you know of a drawback to using this approach?

[pastorhudson]

That is perfect! I'll test it! Or a pull request would be great

[pastorhudson]

The only think I can think of is that right now we have check_name who's job is to verify they have at least a first and last name, and explain this needs to match Planning Center for the authentication to work. It's now obvious it doesn't quite work. What's your thoughts on this?

I think it's pretty messy how I have it currently implemented.

[javb99]

It seems like this change would make check_name unneeded because a blank name on slack would probably not filter anyone out so the email check would still work (Edit: Can't have a blank slack name). That brings up the question should we check the name and the email in a replacement for check_name?

Also, it seems the get(message, app) checks the email, but get_apps(message) doesn't check the email so it would probably have issues if two people had the same name.

[pastorhudson]

Really good points.

I agree check name won't be needed anymore.
I also want to add the auth failure response to the authenticate.get so we can clean up the responces and get rid of duplicate code.

get_apps will need to be updated too.

[pastorhudson]

After testing fl_name = {'search_name_or_email': message.sender['source']['real_name']} I found it to be very very slow. It returns too many results that have to be parsed. Any other ideas?

[javb99]

We could only do it conditionally if the full name has more than 2 components.

[pastorhudson]

It was so slow It feels like it Isn’t working at all. User will probably keep resubmitting the request 🤔