Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen: don't let Elm UI defaults to leak #5

Open
passiomatic opened this issue Jan 3, 2021 · 0 comments
Open

Codegen: don't let Elm UI defaults to leak #5

passiomatic opened this issue Jan 3, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@passiomatic
Copy link
Owner

passiomatic commented Jan 3, 2021

Currently code emitter tries to reduce to write redundant values like: zero padding, zero spacing, "regular" font weight, etc.

This is great but for certain elements this causes to Elm UI to pick its default values in the generate Elm code. I'll keep the list updated with the values that needs to be specified even if they are zero:

  • Padding for text fields
  • ✅ Background color for text fields
  • Border corner for text fields and buttons

This boils down to check for Node.type_ and decide what to do while emitting each style.

@passiomatic passiomatic added the bug Something isn't working label Jan 3, 2021
@passiomatic passiomatic self-assigned this Jan 3, 2021
@passiomatic passiomatic changed the title Codegen: don't let Elm UI defaults leak Codegen: don't let Elm UI defaults to leak Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant