-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Incorporate pulser-pasqal package in the pasqal-cloud repo #147
base: dev
Are you sure you want to change the base?
Conversation
Note for reviewers: Reviewing one commit at a time is recommended on this one |
I think this is ready for review now. I don't think any of these changes has a place in the CHANGELOG but let me know otherwise. |
No, these don't reflect a direct change in the cloud release so changelog is OK without an update. But this leaves me to assume you think we should bump the cloud version to twin with the pulser-pasqal lib in another MR? if I've missed it please point me to it. I think this looks OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
As is, is this going to release new versions of pulser pasqal upon merging to main? Or are there extra steps needed (apart from bumping the version to 1.x to publish a newer version number)
@oliver-gordon @MatthieuMoreau0
EDIT: I guess we can also set the CI workflow to |
I am wondering if the bump to 0.21.0 would be clearer for the previous user of pulser pasqal ? It is a bit a breaking change in some way. I am not sure though. It is fine yes if there is no feature added (or one changed). I guess it would be great to have the documentation about how to use pulser-pasqal feature somewhere in it. |
For the user, there is no breaking change since the library itself did not change. I think 0.20.2 makes sense. |
Description
pasqal_cloud
package inside thepasqal-cloud
directorypulser-pasqal
directory with thepulser_pasqal
packageRemaining Tasks
pulser-pasqal
in themypy
checksChecklist
Versioning (PASQAL developers only)
VERSION.txt
following the changes in your PR and by using semantic versioning.Documentation
Tests
Internal tests pipeline (PASQAL developers only)
If your PR hasn't changed any functionality, it still needs to be validated against internal tests.
After updating the version (PASQAL developers only)