Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for the definition of a custom phase jump time in Channel #762

Open
HGSilveri opened this issue Nov 19, 2024 · 0 comments
Open

Allow for the definition of a custom phase jump time in Channel #762

HGSilveri opened this issue Nov 19, 2024 · 0 comments
Assignees
@HGSilveri
Labels
good first issue Good for newcomers
Milestone
v1.2

Comments

@HGSilveri
Copy link
Collaborator

Right now, Channel.phase_jump_time is always taken to be 2 * rise_time. However, in some cases we might want to set a custom value for this parameter, so we should allow that via custom_phase_jump_time: int | None.
@HGSilveri HGSilveri added the good first issue Good for newcomers label Nov 19, 2024
@HGSilveri HGSilveri added this to the v1.2 milestone Nov 22, 2024
@HGSilveri HGSilveri self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HGSilveri HGSilveri

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v1.2
Development

No branches or pull requests
1 participant
@HGSilveri