Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "run benchmark" command support #73

Closed
bkontur opened this issue Jan 23, 2024 · 3 comments
Closed

Add "run benchmark" command support #73

bkontur opened this issue Jan 23, 2024 · 3 comments

Comments

@bkontur
Copy link

bkontur commented Jan 23, 2024

I am just thinking, as a part of fellows repo issue, I would like to add CI pipeline for testing "benchmarks" - like we have short-benchmark* jobs in polkadot-sdk.
Encointer was merged to fellows without even noticing that benchmarks do not work see.
We've merged chain-spec-generator to fellows, so the only puzzle missing is how to run them without need to rebuild polkadot binary in fellows CI. E.g.

I think, there are two solutions:

  1. release polkadot binary built with `--features runtime-benchmarks"
  2. extend this try-runtime-cli - we are already using this binary for check-migrations, so maybe it could be possible to extend and just reuse this binary for running short benchmarks.

I think that testing/running benchmarks seems to be part of "try runtime" functionality :)

@bkontur
Copy link
Author

bkontur commented Jan 23, 2024

@bkchr @ggwpez guys, wdyt?

@ggwpez
Copy link
Member

ggwpez commented Jan 23, 2024

so the only puzzle missing is how to run them without need to rebuild polkadot binary in fellows CI. E.g.

Yea i thought about this. It should be possible to build the benchmark pallet command as freestanding binary that works with any runtime.
But i dont see this as part of try-runtime. It can just be a freestanding bench runner binary.
For the other benchmarking commands its more difficult, since they actually use the node to author a block.

@liamaharon
Copy link
Contributor

As @ggwpez mentioned, hopefully this will be added to the polkadot node soon.

Will try to keep try-runtime limited to operations related to calling into development runtime apis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants