Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace pallet data is incorrect #297

Open
sacha-l opened this issue Aug 29, 2022 · 6 comments
Open

Marketplace pallet data is incorrect #297

sacha-l opened this issue Aug 29, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@sacha-l
Copy link
Contributor

sacha-l commented Aug 29, 2022

It looks like the pallet READMEs on Marketplace aren't pulling from the right source.

For example, pallet-identity has the link identity::Trait which isn't the right information as written in the source code.

It looks like this is the case for all the FRAME pallets listed.

@sacha-l sacha-l added the bug Something isn't working label Aug 29, 2022
@rmnprkrl
Copy link
Contributor

rmnprkrl commented Aug 29, 2022

@sacha-l I've switched to fetch the data from production API endpoint:
paritytech/substrate-marketplace-website#37
Could you check if this fixed the data issue?

If not we need to check with @stiiifff who built the backend.
FYI @jonnysmillie ^^

@jonnysmillie
Copy link
Contributor

I don't think this has fixed the issue. The link is still the same on the pallet-identity page.

The example issue link returns a 404: https://docs.rs/pallet-assets/latest/pallet_assets/trait.Trait.html

It seems like it could be a mistyped variable as Trait appears to being passed as the trait when it should be Config.

e.g.
https://docs.rs/pallet-assets/latest/pallet_assets/trait.Trait.html results in a 404.
https://docs.rs/pallet-identity/latest/pallet_identity/trait.Config.html appears to be the correct link.

It seems that many other links are broken in the body content too. For example on the /pallets/pallet-assets/ page.

@stiiifff
Copy link

I think I know what the problem is, can you open an issue on the marketplace backend's repo, I'll take a look when I have a bit of bandwidth.

@sacha-l
Copy link
Contributor Author

sacha-l commented Aug 31, 2022

Great - thanks @stiiifff. Just opened an issue there. My high level understanding of the issue is that its pulling from crates.io which has outdated version published (for example, https://crates.io/crates/pallet-identity) where really it should be getting all the info from the READMEs in FRAME's master branch. Until we figure out FRAME pallet releases on crates.io.. 😅

@stiiifff
Copy link

@sacha-l yeah indeed, I think I was a bit too optimistic about seeing official releases landing on crates when I wrote that code. Also, I wanted to avoid if possible the whole Markdown -> HTML formatting / rendering class of issues.

@jonnysmillie
Copy link
Contributor

Hey @stiiifff @sacha-l just wondering if we are any closer to resolving this and if there's anything I can do to help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants