-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create alpine
release of revive compiler (musl.libc)
#45
Comments
The musl build should be beneficial for the remix backend. |
Glibc version should not be necessary. A statically linked revive-musl should have zero dependencies. Hence it will also run on glibc distros. |
@wpt967 Can you take care of this and then go back to the debugging work? It will essentially mean creating github actions to produce the two artifacts (1 + 2). |
Sure. |
@wpt967 thanks a lot! I think how we should do it for now: The musl workflow should only run on pushes to the main branch and depend on the success of build-ubuntu-x86 (see here). This second workflow can then just build musl, build revive linked against musl, and finally build and publish an alpine Docker image containing the musl revive build. Should probably also just add a Makefile target install-musl that produces a release build of revive linked against musl. So, essentially each time we push something to main and the CI passes we'll get a fresh image, which should be good to iterate quickly. Later we can think how to do releases properly (we also want some matrix testing against |
In the Docker image, we need to include both 'resolc-musl' and 'solc-musl'. I would like to ask you to create the first revive release, which I can use as the base for the revive-remix-backend. |
I wouldn't add the |
I just wanted to emphasize that we need both in the musl versions. We shouldn't have any suffix. |
https://gitlab.com/taricorp/llvm-sys.rs/-/issues/44 With this we can give it at shot again. Just need to make sure we pull in the latest version through |
|
So there is an issue with llvm-system which is fixed on master but no release, yet? |
No, sorry I didn't realize it. They backported the fix to llvm-sys |
Create the release workflow for
revive
compiler.As artefacts provide:
revive-glibc versionThe text was updated successfully, but these errors were encountered: