Support collecting system information on Windows

[nazar-pc]

Is there an existing issue?

• I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

• This is not a support question.

Motivation

We have ~61% of consensus nodes running Windows right now and have no idea what systems they are running it on.

Currently Substrate only collects system information on Linux systems, which is a problem:

polkadot-sdk/substrate/client/sysinfo/src/sysinfo.rs

Lines 305 to 321 in 88d900a

	/// Gathers information about node's hardware and software.
	pub fn gather_sysinfo() -> SysInfo {
	#[allow(unused_mut)]
	let mut sysinfo = SysInfo {
	cpu: None,
	memory: None,
	core_count: None,
	linux_kernel: None,
	linux_distro: None,
	is_virtual_machine: None,
	};
	#[cfg(target_os = "linux")]
	crate::sysinfo_linux::gather_linux_sysinfo(&mut sysinfo);
	sysinfo
	}

Request

Collect system information on Windows similarly to how it is done on Linux.

There is unfortunately a hardcoded notion of "Linux Kernel" and "Linux Distro", would be nice to convert it to "OS kernel" and "OS Version" or something like that to be able to distinguish Windows versions as well (10 vs 11 vs various server editions, maybe Home/Pro/Enterprise flavors).

Solution

No response

Are you willing to help with this request?

Maybe (please elaborate above)

[bkchr]

Feel free to open a pr that adds support for it, but we don't have any CI jobs right now that will ensure that this doesn't break.

For linux_distro and linux_kernel, the best for now would be probably to put Windows as distro and the version as kernel. We will need to change the telemetry backends to support any new variants, but I would do this as a second step.