Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network: Remove CLI flag for yamux_window_size #6468

Open
lexnv opened this issue Nov 13, 2024 · 0 comments · May be fixed by #7014
Open

network: Remove CLI flag for yamux_window_size #6468

lexnv opened this issue Nov 13, 2024 · 0 comments · May be fixed by #7014
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK.

Comments

@lexnv
Copy link
Contributor

lexnv commented Nov 13, 2024

The yamux window size is no longer configurable in libp2p:

Instead, the yamux implementation will use an auto tuning algoirhtm backported from Quic for performance improvements.

Litep2p will follow with a similar approach soon and then this flag will no longer be needed:
network_config.yamux_window_size
@lexnv lexnv added this to Networking Nov 13, 2024
@bkchr bkchr added C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. labels Dec 29, 2024
@qiweiii qiweiii linked a pull request Dec 30, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK.
Projects
Networking
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove yamux_window_size from network config qiweiii/polkadot-sdk
2 participants
@bkchr @lexnv