Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add claim_assets extrinsic to pallet-xcm and make it available in next runtime release #3495

Closed
4 tasks done
acatangiu opened this issue Feb 27, 2024 · 6 comments
Closed
4 tasks done

Add claim_assets extrinsic to pallet-xcm and make it available in next runtime release #3495

acatangiu opened this issue Feb 27, 2024 · 6 comments
Assignees
@franciscoaguirre
Labels
I5-enhancement An additional feature request. T6-XCM This PR/Issue is related to XCM.

Comments

@acatangiu
Copy link
Contributor

acatangiu commented Feb 27, 2024 •
edited by bkontur
Loading

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Motivation

If an XCM execution fails or ends with leftover assets, these will be trapped.
In order to claim them, a custom XCM has to be executed, with the ClaimAsset instruction.
However, arbitrary XCM execution is not allowed everywhere yet and XCM itself is still not easy enough to use for users out there with trapped assets.

Request

Add new extrinsic in pallet-xcm to allow users to easily claim their assets, without concerning themselves with writing arbitrary XCMs.

Backport the solution to polkadot-sdk v1.7.0, release patched pallet-xcm crate, add it to https://github.com/polkadot-fellows/runtimes to make it available with upcoming v1.2.0 runtimes release.

Solution

Are you willing to help with this request?

Yes!
@acatangiu acatangiu added the I5-enhancement An additional feature request. label Feb 27, 2024
@acatangiu acatangiu mentioned this issue Feb 27, 2024
Merged
@acatangiu acatangiu added the T6-XCM This PR/Issue is related to XCM. label Mar 1, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 1, 2024
@franciscoaguirre @acatangiu
Add claim_assets extrinsic to pallet-xcm (#3403)
6508866 
If an XCM execution fails or ends with leftover assets, these will be
trapped.
In order to claim them, a custom XCM has to be executed, with the
`ClaimAsset` instruction.
However, arbitrary XCM execution is not allowed everywhere yet and XCM
itself is still not easy enough to use for users out there with trapped
assets.
This new extrinsic in `pallet-xcm` will allow these users to easily
claim their assets, without concerning themselves with writing arbitrary
XCMs.

Part of fixing #3495

---------

Co-authored-by: command-bot <>
Co-authored-by: Adrian Catangiu <[email protected]>
franciscoaguirre added a commit that referenced this issue Mar 1, 2024
@franciscoaguirre @acatangiu
Add claim_assets extrinsic to pallet-xcm (#3403)
859179f 
If an XCM execution fails or ends with leftover assets, these will be
trapped.
In order to claim them, a custom XCM has to be executed, with the
`ClaimAsset` instruction.
However, arbitrary XCM execution is not allowed everywhere yet and XCM
itself is still not easy enough to use for users out there with trapped
assets.
This new extrinsic in `pallet-xcm` will allow these users to easily
claim their assets, without concerning themselves with writing arbitrary
XCMs.

Part of fixing #3495

---------

Co-authored-by: command-bot <>
Co-authored-by: Adrian Catangiu <[email protected]>
skunert pushed a commit to skunert/polkadot-sdk that referenced this issue Mar 4, 2024
@franciscoaguirre @acatangiu @skunert
Add claim_assets extrinsic to pallet-xcm (paritytech#3403)
e8051ac 
If an XCM execution fails or ends with leftover assets, these will be
trapped.
In order to claim them, a custom XCM has to be executed, with the
`ClaimAsset` instruction.
However, arbitrary XCM execution is not allowed everywhere yet and XCM
itself is still not easy enough to use for users out there with trapped
assets.
This new extrinsic in `pallet-xcm` will allow these users to easily
claim their assets, without concerning themselves with writing arbitrary
XCMs.

Part of fixing paritytech#3495

---------

Co-authored-by: command-bot <>
Co-authored-by: Adrian Catangiu <[email protected]>
@bkontur
Copy link
Contributor

bkontur commented Mar 5, 2024

Merged to the fellows main as a part of polkadot-fellows/runtimes#187

What about backport to 1.8.0?

@acatangiu
Copy link
Contributor Author

I am generally against unneeded/unrequested backports. We could do it lazily when someone requests it. We know that for system runtimes we don’t need it in 1.8

@acatangiu
Copy link
Contributor Author

Fixed in polkadot-fellows/runtimes#187

@bkontur
Copy link
Contributor

bkontur commented Mar 5, 2024

I am generally against unneeded/unrequested backports. We could do it lazily when someone requests it. We know that for system runtimes we don’t need it in 1.8

yes, agree, but if we want to release next polkadot 1.3.0 just with 1.8.0 (without 1.9.0) we will need to backport anyway

@decentration
Copy link

i think i need this, i have an issue that requires claiming 1499 DOT that just got trapped in Polkadot chain, the call i have curated cannt be called because it would exhaust block limits. can someone give me a pointer?

https://substrate.stackexchange.com/questions/11228/assettrapped-i-teleported-1499-dot-from-polkadot-to-assethub-but-it-has-not-arr

@acatangiu
Copy link
Contributor Author

Yes, you need this, also answered on SE.
Runtimes 1.2.0 was just released. Once upgraded on-chain, you'll have access to the claim_assets extrinsic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franciscoaguirre franciscoaguirre

Labels
I5-enhancement An additional feature request. T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@franciscoaguirre @bkontur @acatangiu @decentration