From 625d4f13d27ddbe669d9f3448cc447ec9279e44f Mon Sep 17 00:00:00 2001
From: Javier Bullrich <javier@bullrich.dev>
Date: Mon, 8 Apr 2024 13:35:54 +0200
Subject: [PATCH] modified step order

MAybe this makes it work better?
---
 .github/workflows/review-trigger.yml | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/review-trigger.yml b/.github/workflows/review-trigger.yml
index c9968097e5124..6db6208c1cadd 100644
--- a/.github/workflows/review-trigger.yml
+++ b/.github/workflows/review-trigger.yml
@@ -29,8 +29,6 @@ jobs:
           github.event.action == 'synchronize' && 
           github.event.sender.login == github.event.pull_request.user.login
         run: |
-          echo "::error::Project needs to be reviewed again"
-
           # We get the list of reviewers who approved the PR
           REVIEWERS=$(gh api repos/${{ github.repository }}/pulls/${{ github.event.number }}/reviews \
           --jq '{reviewers: [.[] | select(.state == "APPROVED") | .user.login]}')
@@ -40,18 +38,20 @@ jobs:
           echo "commenters=COMMENTS" >> "$GITHUB_OUTPUT"
 
           echo "Commeneters are $COMMENTS"
+
+          echo "::error::Project needs to be reviewed again"
           
           # We request them to review again
           echo $REVIEWERS | gh api --method POST repos/${{ github.repository }}/pulls/${{ github.event.number }}/requested_reviewers --input -
           exit 1
         env:
           GH_TOKEN: ${{ github.token }}
-      - name: Comment requirements
-        if: failure() && ${{ contains(steps.fail.output.commenters, 'github-action') }}
-        run: |
-          echo "OH NO!"
-        env:
-          GH_TOKEN: ${{ github.token }}
+      # - name: Comment requirements
+      #   if: failure() && ${{ contains(steps.fail.output.commenters, 'github-action') }}
+      #   run: |
+      #     echo "OH NO!"
+      #   env:
+      #     GH_TOKEN: ${{ github.token }}
       - name: Get PR number
         env:
           PR_NUMBER: ${{ github.event.pull_request.number }}