Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

area/ui: auto close the group by dropdown when there's an outside click #5381

Merged
merged 1 commit into from
Dec 11, 2024
Merged

area/ui: auto close the group by dropdown when there's an outside click #5381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion ui/packages/shared/profile/src/ProfileView/components/ActionButtons/GroupByDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,25 @@ const GroupByDropdown: React.FC<GroupByDropdownProps> = ({
labelsButtonRef,
}) => {
const [isDropdownOpen, setIsDropdownOpen] = useState(false);
const dropdownRef = useRef<HTMLDivElement>(null);

useEffect(() => {
const handleClickOutside = (event: MouseEvent): void => {
if (
isDropdownOpen &&
dropdownRef.current != null &&
!dropdownRef.current.contains(event.target as Node)
) {
setIsDropdownOpen(false);
}
};

document.addEventListener('mousedown', handleClickOutside);
return () => {
document.removeEventListener('mousedown', handleClickOutside);
};
}, [isDropdownOpen]);

const label =
groupBy.length === 0
? 'Nothing'
Expand All @@ -179,7 +198,7 @@ const GroupByDropdown: React.FC<GroupByDropdownProps> = ({
.map(l => l.slice(FIELD_LABELS.length + 1));

return (
<div className="relative">
<div className="relative" ref={dropdownRef}>
<label className="text-sm">Group by</label>
<div className="relative text-left" id="h-group-by-filter">
<Button
Expand Down
Loading