Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

area/ui: auto close the group by dropdown when there's an outside click #5381

Merged
merged 1 commit into from
Dec 11, 2024
Merged

area/ui: auto close the group by dropdown when there's an outside click #5381

merged 1 commit into from
Dec 11, 2024

Conversation

yomete
Copy link
Contributor

@yomete yomete commented Dec 11, 2024

Fixes #5378

@yomete yomete requested a review from a team as a code owner December 11, 2024 13:29
@alwaysmeticulous alwaysmeticulous
Copy link

alwaysmeticulous bot commented Dec 11, 2024 •
edited
Loading

🤖 Meticulous spotted visual differences in 4 of 223 screens tested: view and approve differences detected.

Meticulous simulated ~5 hours of user flows against your PR.

Last updated for commit 68d4a3e. This comment will update as new commits are pushed.

manojVivek
manojVivek approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@yomete yomete merged commit c8b98c9 into main Dec 11, 2024
38 checks passed
@yomete yomete deleted the auto-dismiss-groupby branch December 11, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manojVivek manojVivek manojVivek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Group-by menu doesn't close as expected
2 participants
@yomete @manojVivek