Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

area/ui: Add a popover menu to the AreaGraph component #5364

Merged
merged 6 commits into from
Dec 10, 2024

Conversation

yomete
Copy link
Contributor

@yomete yomete commented Dec 5, 2024

No description provided.

@yomete yomete requested a review from a team as a code owner December 5, 2024 14:59
@yomete yomete changed the title Add a popover menu to the AreaGraph component area/ui: Add a popover menu to the AreaGraph component Dec 5, 2024
Copy link

alwaysmeticulous bot commented Dec 5, 2024

🤖 Meticulous spotted visual differences in 1 of 219 screens tested: view and approve differences detected.

Meticulous simulated ~4 hours of user flows against your PR.

Last updated for commit b54dff8. This comment will update as new commits are pushed.

Copy link
Contributor

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change, looks great otherwise.

<div className="flex gap-1 items-center">
<div>Timestamp:</div>
<div className="text-gray-600 dark:text-gray-300">
{formatDate(timestamp, timePattern(timezone), timezone)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make more sense to display the time with milliseconds precision here.
When the timeframe is tight, we'll have multiple points within a second and milliseconds precision would really help.

@pre-commit-ci-lite pre-commit-ci-lite bot requested a review from a team as a code owner December 10, 2024 13:28
@yomete yomete merged commit 71ac4ff into main Dec 10, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants