Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide nextjs feature toggle HOC. #84

Open
2 tasks
kennylavender opened this issue Sep 26, 2019 · 0 comments
Open
2 tasks

Provide nextjs feature toggle HOC. #84

kennylavender opened this issue Sep 26, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@kennylavender
Copy link
Contributor

kennylavender commented Sep 26, 2019

Design and implement a nextjs HOC that assists users in toggling content and status's based on active/inactive features. It should

  • render the correct page on both the server and client
  • send the correct status code from the server

Post suggestions for the HOC API here for discussion.

I believe nextjs requires that getInitialProps sets status code in order to accomplish the goals above.

Some details here: #37 (comment)

Don't export the new HOC in src/index.js. We want users to manually import this separate from the main module to avoid code bloat for those that don't use nextjs. See how RITEway provide render-component as an example

@kennylavender kennylavender added the enhancement New feature or request label Sep 26, 2019
@kennylavender kennylavender changed the title Provide nextjs 404 HOC. Provide nextjs feature toggle HOC. Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant