-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Squash and Merge on every repo and document merge procedure #131
Comments
Might be worth mentioning that pull-request templates may help. For example: Markdown:
Preview:What changes does this PR make?:Details... Issue:Fixes #ISSUE_NUMBER Merge Method:
|
This is my personnal opinion but in general I am not a fan of templates 😬. About the Merge Method (which was the original goal for the template, sorry to disgress 🙄) I have the same thinking than above: some new contributors might not even know about those merge method and what to do. I would say that for maintainers, in most cases there are two choices what to do:
This is all my personal opinion though! |
Yeah I agree. I don't really mind either way; I kind of have a love hate relationship with templates. On the one hand it makes sure you get all of the information you need in a structured official format. On the other hand I don't like them because it seems verbose and takes extra time. It also disables stuff like auto filling the commit messages in the PR description which is annoying 😢 was just aiming to voice the suggestion mainly |
This was discussed on the community meeting, see the related minutes here.
This is about two things:
The text was updated successfully, but these errors were encountered: