Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trie): witness generation #12859

Open
rkrasiuk opened this issue Nov 26, 2024 · 0 comments · May be fixed by #13072
Open

fix(trie): witness generation #12859

rkrasiuk opened this issue Nov 26, 2024 · 0 comments · May be fixed by #13072
Assignees
@rkrasiuk
Labels
A-trie Related to Merkle Patricia Trie implementation C-bug An unexpected or incorrect behavior

Comments

@rkrasiuk
Copy link
Member

Description

Generated witness does not always include all the nodes as shown in main...meyer9:reth:meyer9/account-proof-test

This is caused by next_root_from_proofs function not being robust enough when determining which trie node to pass to the hash builder.

Fix

Remove next_root_from_proofs and integrate witness with SparseTrie.
@rkrasiuk rkrasiuk added A-trie Related to Merkle Patricia Trie implementation C-bug An unexpected or incorrect behavior labels Nov 26, 2024
@rkrasiuk rkrasiuk self-assigned this Nov 26, 2024
This was referenced Nov 26, 2024
Merged
Merged
Merged
Merged
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkrasiuk rkrasiuk

Labels
A-trie Related to Merkle Patricia Trie implementation C-bug An unexpected or incorrect behavior
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(witness): collect witness using sparse trie paradigmxyz/reth
1 participant
@rkrasiuk