Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Refactor workspace and add pg_analytics module #149

Closed
wants to merge 4 commits into from
Closed

refactor: Refactor workspace and add pg_analytics module #149

wants to merge 4 commits into from

Conversation

Weijun-H
Copy link
Contributor

@Weijun-H Weijun-H commented Oct 9, 2024

philippemnoel
philippemnoel requested changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@philippemnoel philippemnoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I'm in favour of this. Why do we need to create a workspace out of this project to add tests? Can't the sqllogictests be added under /tests/?

@Weijun-H
Copy link
Contributor Author

I thought of an easier way to do this without moving the src

@Weijun-H Weijun-H closed this Oct 11, 2024
@philippemnoel
Copy link
Collaborator

I thought of an easier way to do this without moving the src

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippemnoel philippemnoel philippemnoel requested changes

@rebasedming rebasedming Awaiting requested review from rebasedming rebasedming is a code owner

@neilyio neilyio Awaiting requested review from neilyio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the workspace feature of Cargo to include sqllogictests and pg_analytics two packages
2 participants
@Weijun-H @philippemnoel