-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump duckdb-rs version #174
Conversation
This PR would need documentation so people know how to use it |
just fix the packages and now i can build it and test it locally it seems there's no |
Yes, that’s because duckdb-rs is on duckdb 1.0.0, not 1.1.0 which it seems like it needs. We would need you to submit a PR to our fork to duckdb-rs to upgrade it as well there, then update the commit here. |
from https://github.com/paradedb/duckdb-rs/tree/main/crates/libduckdb-sys it seems it's already on |
Ah yes! You are right! Oops, I had no idea. Then, I'm not sure... Are you sure this is supported? Do we need to do anything to enable it? |
Could you please sign the CLA and I think this will be good to go :) |
done :) for the geoparquet reference, i think it need some extra data type mapping (especially postgis geometry) |
We ship with Postgis support and the spatial extension is enabled in |
not enough at the moment. load spatial;
create table gis_test as select st_makepoint(127.0, 30.0) as geometry;
copy gis_test to '~/Downloads/gis_test.parquet' (format parquet);
create table gis2 as select * from '~/Downloads/gis_test.parquet';
describe table gis2;
┌─────────────┬─────────────┬─────────┬─────────┬─────────┬─────────┐
│ column_name │ column_type │ null │ key │ default │ extra │
│ varchar │ varchar │ varchar │ varchar │ varchar │ varchar │
├─────────────┼─────────────┼─────────┼─────────┼─────────┼─────────┤
│ geometry │ GEOMETRY │ YES │ │ │ │
└─────────────┴─────────────┴─────────┴─────────┴─────────┴─────────┘ but in pg_analytics, it still read it as text column CREATE FOREIGN TABLE gis2 () server parquet_server options(files '~/Downloads/gis_test.parquet');
select * from information_schema.columns where table_schema = 'public' and table_name = 'gis2' and column_name = 'geometry';
select column_name, data_type from information_schema.columns where table_schema = 'public' and table_name = 'gis2' and column_name = 'geometry';
column_name | data_type
-------------+-----------
geometry | text
(1 row) |
Can you confirm the duckDB version you are using separately? And can you confirm the GIS extension is loaded in pg_analytics? |
confirm duckdb version confirm tried |
I think you would need to
|
Ticket(s) Closed
What
support reading and writing geoparquet
Why
with
duckdb_spatial>=v1.1.0
geometry column in parquet will be read/write as geometry instead of blobHow
no explicit change of sql is needed
Tests
a read/write parquet test should be added later