Request is not marked as authenticated after successful authenticaiton

[dsrvasanth]

Hi @panva, i was following one of your sample
#195 (comment), and modified slightly to include logout handler and file based session store as given below. It looks like some race condition is going on, and in the login callback successRedirect call the req object is not marked as authenticated.

'use strict';

const util = require('util');

const express = require('express');
const app = express();

const passport = require('passport');
const { Strategy, Issuer } = require('openid-client');
var session = require('express-session');

var FileStore = require('session-file-store')(session);
var fileSessionStore =  new FileStore();

(async () => {
  const issuer = await Issuer.discover('...');
  const client = new issuer.Client({
    client_id: '...',
    client_secret: '...',
    redirect_uris: [ 'http://localhost:3000/callback' ],
    post_logout_redirect_uris: [ 'http://localhost:3000/logout/callback' ],
    token_endpoint_auth_method: 'client_secret_post'
  });

  console.log('registered client', client.metadata);

  passport.serializeUser(function (user, done) {
    done(null, user);
  });

  passport.deserializeUser(function (user, done) {
    done(null, user);
  });

  passport.use('panva.cz', new Strategy({ client },  (tokenSet, userinfo, done) => { 
    return done(null, {userinfo: userinfo, tokens: tokenSet});
  }));

  app.use(session({ store: fileSessionStore, secret: 'keyboard cat', resave:true, saveUninitialized:true }));
  app.use(passport.initialize());
  app.use(passport.session());

  app.get('/', function (req, res) {
    res.send(util.format('Hello %s!', req.isAuthenticated() ? req.user.tokens +'</br> <a href="/logout">Logout</a>' : 'Anonymous. <a href="/auth">Authenticate</a>'));
  });

  app.get('/auth', passport.authenticate('panva.cz'));
  app.get('/callback', passport.authenticate('panva.cz', { successRedirect: '/', failureRedirect: '/' }));
    
  app.get('/logout', (req, res) => {
    res.redirect(client.endSessionUrl({'id_token_hint': req.user.tokens.id_token}));
  });

  app.get('/logout/callback', (req, res) => {
    req.logout();
    res.redirect('/');
  });

  app.listen(3000, function () {
    console.log('Example app listening on port 3000!');
  });
})().catch((err) => {
  console.error(err);
  process.exit(1);
});

[panva]

Seems to be related to your session store. Just omitting it entirely it works as expected.

[dsrvasanth]

You are correct. Looks like SessionFileStore has some issues. When I switch the session store to inmemory or redis, it works as expected. Thanks for the help!!!

[panva]

You are welcome. Please consider supporting the library if it provides value to you or your company and this support was of help to you. Supporting the library means, amongst other things, that such support will be available in the future.