Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure 404 page is visible for all wrong URLs #7

Closed
huonw opened this issue Dec 30, 2023 · 5 comments · Fixed by #84
Closed

Ensure 404 page is visible for all wrong URLs #7

huonw opened this issue Dec 30, 2023 · 5 comments · Fixed by #84
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@huonw
Copy link
Contributor

huonw commented Dec 30, 2023

From #4:

A "404" shows the menu structure but no actual content: https://docs.pantsbuild.org/xyz/abc. It'd be good to have some sort of real content describing the problem.

@huonw huonw added this to the Switch-over milestone Dec 31, 2023
@huonw huonw added the enhancement New feature or request label Dec 31, 2023
@huonw huonw changed the title Create a useful 404 page Ensure 404 page is visible for wrong URLs Dec 31, 2023
@huonw huonw changed the title Ensure 404 page is visible for wrong URLs Ensure 404 page is visible for all wrong URLs Dec 31, 2023
@huonw
Copy link
Contributor Author

huonw commented Dec 31, 2023

Ah, broken URLs under a version do show a useful 404: https://docs.pantsbuild.org/2.19.x/abc ... so this is more about making sure that's always shown.

@thejcannon
Copy link
Member

Also, for reference here's the existing 404 page: https://www.pantsbuild.org/docs/foo

@thejcannon
Copy link
Member

OK so spinning up a new docs site, it does 404 correctly. So far I haven't been able to deduce what's different about our little slice of heaven and a fresh docs site that'd cause this.

@thejcannon
Copy link
Member

thejcannon commented Jan 2, 2024

OK I've narrowed it down to what appears to be "disableVersioning: true" making the top-level 404 page be blank...

which is weird because that should be false on prod...

@thejcannon
Copy link
Member

Alright, so poking at it more, this just looks like a Docusuarus bug: facebook/docusaurus#9688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment