Clear preferred version setting "cookie" when new version is released

[huonw]

It seems the "default" version is 2.18, but we've released 2.19.0 stable, so 2.19 should be the default. For example, the links in the navbar are:

• "docs": https://www.pantsbuild.org/2.18/docs/introduction/welcome-to-pants
• "reference": https://www.pantsbuild.org/2.18/reference/global-options

[huonw]

Hm, I cannot reproduce this locally either with npm start or npm run build. 🤷

[tgolsson]

🍪 . (Though actually local storage: docs-preferred-version-default: 2.18). Will fix the title.

[huonw]

Huh, good catch! Do you know if that cookie can be controlled by users explicitly and/or how it gets set?

Just thinking that if a user is, say, using 2.16 and sets that as their preferred version, it'd be suboptimal to clear it. (It's probably tolerable, just trying to explore the possible "breakage" explicitly.)

[kaos]

I experimented a bit with this after reading Tom's comment as well.. and from what I could tell, the "preferred version" is only set when selecting a particular version from the drop down, which is limited to only the most recent few versions.. if I go back to the "all versions" page there are (currently broken) links, which doesn't seem to stick when followed. Which makes this less of an issue I think.