From c702965fdcb3b54078942e9d616e5dd8af50ce0a Mon Sep 17 00:00:00 2001 From: Kevin Porras Date: Thu, 11 Jan 2024 12:27:15 -0600 Subject: [PATCH] Default max retries var was not defined. (#2529) * Default max retries var was not defined. * Update version and changelog. [skip ci] --- CHANGELOG.md | 6 +++++- config/constants.yml | 2 +- src/Request/Request.php | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6297ae857..6d486d07d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,11 @@ # Change Log All notable changes to this project will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org) -## 3.3.3-dev - +## 3.3.3 - 2024-01-11 + +### Fixed + +- Undefined variable notice for defaultMaxRetries (#2529) ## 3.3.2 - 2024-01-11 diff --git a/config/constants.yml b/config/constants.yml index 5e21961e9..ab03e46f8 100644 --- a/config/constants.yml +++ b/config/constants.yml @@ -7,7 +7,7 @@ --- # App -TERMINUS_VERSION: '3.3.3-dev' +TERMINUS_VERSION: '3.3.3' # Connectivity TERMINUS_HOST: 'terminus.pantheon.io' diff --git a/src/Request/Request.php b/src/Request/Request.php index 40b6f3520..1c225fea1 100755 --- a/src/Request/Request.php +++ b/src/Request/Request.php @@ -176,7 +176,7 @@ private function getClient($base_uri = null): ClientInterface private function createRetryDecider(): callable { $config = $this->getConfig(); - $maxRetries = $config->get('http_max_retries', $defaultMaxRetries); + $maxRetries = $config->get('http_max_retries', 5); // Cap max retries at 10. $maxRetries = $maxRetries > 10 ? 10 : $maxRetries; $retryBackoff = $config->get('http_retry_backoff', 5);