Javascript object declaration breaking Liquid syntax highlight

[muchisx]

Hi!

So I noticed this, when an object is declared in JS inside a <script> tag on a .liquid file, the highlighting breaks on anything below that declaration.

Like this

[panoply]

Ouff. Good catch. Will do some tests and see what is happening and occurring here.

[panoply]

@muchisx can you try on the latest version? This should be fixed.

[muchisx]

Hey @panoply !

✅ Syntax doesnt brake anymore with JS objects declarations!

---

Maybe totally unrelated but I noticed the IF statemant syntax is no longer detected
I remember setting a color in the following scopes:

"scope": ["entity.name.tag.conditional.liquid", "entity.name.tag.control.liquid"],

but these are not longer detected, should I move it to another issue or this change came with a reason?

[panoply]

Move to another one brother

[muchisx]

Hi @panoply
Just redid some tests, seems like the one with <script> is fixed but the one with {% javascript %} remains as before.

{% javascript %}
  const testString = 'test';
  const testNumber = 9999;
  const testBoolean = false;
  const testArray = ['test', 900, false, {}]
  const testObject = {
    test: 'test',
    testtest: 'testtest',
  }
{% endjavascript %}

{% # Testcomment %}

{% comment %}
  Test comment
{% endcomment %}

<script>
  const text = {
    hey: 'hey'
  }
</script>```