You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2023. It is now read-only.
Just in that example I can see numerous improvements we can make to add comments to the schema. Some of these are:
Is the reserve figure in the native Token or USD?
reserveETH should be renamed to reserveAVAX
reserveETH and reserveUSD are matching. Is this is USD?
token1Price and token2Price doesn't explain if this is compared to each other? It also doesn't explain direction of the comparison. Is it WAVAX-ETH or else ETH-WAVAX
What is the token/currency of totalSupply? USD?
What is the volumeToken0 and volumeToken1 token/currency? Is it the native token or USD?
A lot of these queries can be very simple answered by just including comments in the schema
The text was updated successfully, but these errors were encountered:
I'm busy looking at building a bot that utilises the Pangolin subgraph to work out historical profitability. As part of that I've been playing with the GraphQL API at https://graph-node.avax.network/subgraphs/name/dasconnor/pangolindex
If I look at an example query I've been running:
Just in that example I can see numerous improvements we can make to add comments to the schema. Some of these are:
reserveETH
should be renamed toreserveAVAX
reserveETH
andreserveUSD
are matching. Is this is USD?token1Price
andtoken2Price
doesn't explain if this is compared to each other? It also doesn't explain direction of the comparison. Is it WAVAX-ETH or else ETH-WAVAXvolumeToken0
andvolumeToken1
token/currency? Is it the native token or USD?A lot of these queries can be very simple answered by just including comments in the schema
The text was updated successfully, but these errors were encountered: