Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RLS: 2.3 #59664

Open
2 of 5 tasks
lithomas1 opened this issue Aug 30, 2024 · 13 comments
Open
2 of 5 tasks

RLS: 2.3 #59664

lithomas1 opened this issue Aug 30, 2024 · 13 comments
Labels
Milestone

Comments

@lithomas1
Copy link
Member

lithomas1 commented Aug 30, 2024

Release Date: ???

Features:

cc @pandas-dev/pandas-core

@mroeschke
Copy link
Member

mroeschke commented Aug 30, 2024

I updated the OP with the items to be included in 2.3 based on the pandas dev meeting notes. I believe the release date will be dependent on when the PDEP-14 is implemented and the pandas test suite passes with future.infer_string

The following PRs may need to be backported to 2.3:

These backports probably should probably come before/after #59513 cc @WillAyd

@mroeschke mroeschke added this to the 2.3 milestone Aug 30, 2024
@lithomas1
Copy link
Member Author

List of TODOS for infer_string (including xfailed tests) can be found here I think.

https://github.com/search?q=repo%3Apandas-dev%2Fpandas+TODO%28infer_string%29+language%3APython&type=code

@rhshadrach
Copy link
Member

There is both a 2.3.0 and a 2.3.x branch, which one should we target for PRs?

@WillAyd
Copy link
Member

WillAyd commented Sep 8, 2024

2.3.x I made the 2.3.0 branch by mistake but can't delete it

@rhshadrach
Copy link
Member

@jorisvandenbossche - would you have the ability to delete?

@mroeschke
Copy link
Member

I went ahead and deleted the 2.3.0 branch

@jorisvandenbossche
Copy link
Member

I do wonder if we should consider doing a 2.2.3 with specifically the Python 3.13 and numpy 2.1 changes. Downstream projects might appreciate that we have compatible wheels relatively soon, and when we will be exactly ready for 2.3 is still a bit unsure.

@lithomas1
Copy link
Member Author

I do wonder if we should consider doing a 2.2.3 with specifically the Python 3.13 and numpy 2.1 changes. Downstream projects might appreciate that we have compatible wheels relatively soon, and when we will be exactly ready for 2.3 is still a bit unsure.

That's a good idea.
If we follow the normal release process for 2.3.0, we'd have to do an RC aswell.
Assuming we are able to release an RC next week somehow, that would only leave 2 weeks for addressing any issues from the RC before Python 3.13 comes out, which is a pretty tight schedule.

Personally, I think it's really important that we get a Python 3.13 compatible release out before 3.13 final is due on October 1st.
https://peps.python.org/pep-0719/

Thoughts @pandas-dev/pandas-core?

@jorisvandenbossche
Copy link
Member

I don't think next week is realistic for 2.3.0, based on the current speed of progress (I think end of the month would be my best (optimistic) estimate)

@WillAyd
Copy link
Member

WillAyd commented Sep 10, 2024

I would be OK with another 2.2.3 release if someone had time / interest for it. However, same word of caution as with 2.3 - I think getting the backport branch updated and passing tests is a rather large effort, so don't want to underestimate the time that may take

@mikev-junimo
Copy link

Has the performance regression with infer strings mentioned in #59657 been fixed in 2.3.x? Because when I enable this option in 2.2 I also experience a perf regression.

@jorisvandenbossche
Copy link
Member

@mikev-junimo good question. I took a quick look, and it seems this is not fixed on 2.3.x, only on main (thanks to #57205, but that is not backported). I have opened a smaller PR to also just fix it for 2.3.x: #60461

@mikev-junimo
Copy link

@jorisvandenbossche thanks! I've been wanting to enable it in our env but couldn't due to that bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants