Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: changes for spelling mistakes #56474

Closed
wants to merge 1 commit into from

Conversation

ashishkumar30
Copy link

@ashishkumar30 ashishkumar30 commented Dec 12, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@datapythonista
Copy link
Member

Thanks for the contribution @ashishkumar30, not sure if many of those add much value, but make sure you're not breaking the tests, we test for the messages of exceptions in general, so changing them will make tests fail.

I'd personally prefer if you revert the commas, and also adding the s to Python object names like Categorical or datetime.

@datapythonista datapythonista changed the title changes for spelling mistakes CLN: changes for spelling mistakes Dec 13, 2023
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants