Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Support case insensitive for merge #56447

Closed
1 of 3 tasks
belongwqz opened this issue Dec 11, 2023 · 2 comments
Closed
1 of 3 tasks

ENH: Support case insensitive for merge #56447

belongwqz opened this issue Dec 11, 2023 · 2 comments
Labels
Closing Candidate May be closeable, needs more eyeballs Enhancement

Comments

@belongwqz
Copy link

Feature Type

  • Adding new functionality to pandas

  • Changing existing functionality in pandas

  • Removing existing functionality in pandas

Problem Description

Maybe the merge method should add a case parameter to identify case insensitive.

Feature Description

def merge(self, other, on, case=False, ...):
    self.on_ = self.on.str.lower()
    other.on_ = other.on.str.lower()
    ...

Alternative Solutions

Add a param case to the method merge of dataframe like:a.merge(b, case=False),to identify case insensitive.

Additional Context

No response

@belongwqz belongwqz added Enhancement Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 11, 2023
@mroeschke
Copy link
Member

Thanks for the suggestion but I would be -1 on this enhancement. on can be any type (not just strings) and can be easily done before the merge

@mroeschke mroeschke added Closing Candidate May be closeable, needs more eyeballs and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 11, 2023
@phofl
Copy link
Member

phofl commented Dec 15, 2023

agree with @mroeschke

there is no performance benefit of doing this within merge

@phofl phofl closed this as completed Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closing Candidate May be closeable, needs more eyeballs Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants