Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Fix mypy #56428

Merged
merged 1 commit into from
Dec 9, 2023
Merged

CI: Fix mypy #56428

merged 1 commit into from
Dec 9, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 9, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added this to the 2.2 milestone Dec 9, 2023
@mroeschke mroeschke added CI Continuous Integration Typing type annotations, mypy/pyright type checking labels Dec 9, 2023
@mroeschke mroeschke merged commit f0b61c5 into pandas-dev:main Dec 9, 2023
50 checks passed
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the typing branch December 9, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @mroeschke