Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: is_timedelta64_ns_dtype failing for unitless np.timedelta64 2.1.x #56318

Closed
lithomas1 opened this issue Dec 4, 2023 · 4 comments
Closed
Assignees
Labels
CI Continuous Integration Unreliable Test Unit tests that occasionally fail
Milestone

Comments

@lithomas1
Copy link
Member

lithomas1 commented Dec 4, 2023

_________________________ test_is_timedelta64_ns_dtype _________________________
[gw0] linux -- Python 3.9.15 /home/runner/micromamba/envs/test/bin/python3.9

    def test_is_timedelta64_ns_dtype():
        assert not com.is_timedelta64_ns_dtype(np.dtype("m8[ps]"))
>       assert not com.is_timedelta64_ns_dtype(np.array([1, 2], dtype=np.timedelta64))
E       AssertionError

pandas/tests/dtypes/test_common.py:[51](https://github.com/pandas-dev/pandas/actions/runs/7082249608/job/19272751944?pr=56313#step:8:53)4: AssertionError

This is on the min versions build.

@lithomas1 lithomas1 added CI Continuous Integration Blocker Blocking issue or pull request for an upcoming release labels Dec 4, 2023
@lithomas1 lithomas1 added this to the 2.1.4 milestone Dec 4, 2023
@lithomas1 lithomas1 self-assigned this Dec 4, 2023
@lithomas1 lithomas1 added the Unreliable Test Unit tests that occasionally fail label Dec 4, 2023
@lithomas1
Copy link
Member Author

Not really a blocker but we should investigate further before the release.

I can't seem to reproduce it locally, though.

@mroeschke mroeschke changed the title CI: Strange failure on 2.1.x CI: is_timedelta64_ns_dtype failing for unitless np.timedelta64 2.1.x Dec 4, 2023
@phofl
Copy link
Member

phofl commented Dec 7, 2023

it seems flaky

@lithomas1 lithomas1 removed the Blocker Blocking issue or pull request for an upcoming release label Dec 8, 2023
@lithomas1
Copy link
Member Author

Yeah, looks like it is.

Seems to fail most of the time, though.
I think I'm comfortable releasing even with it failing, given that this is just the minimum versions build.

@lithomas1
Copy link
Member Author

lithomas1 commented Dec 8, 2023

Closing, didn't happen on the release (luckily), and not relevant for main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Unreliable Test Unit tests that occasionally fail
Projects
None yet
Development

No branches or pull requests

2 participants