Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG / CoW: ensure ser[...] (indexing with Ellipsis) returns new object #56314

Merged
merged 2 commits into from
Dec 4, 2023
Merged

BUG / CoW: ensure ser[...] (indexing with Ellipsis) returns new object #56314

merged 2 commits into from
Dec 4, 2023

Conversation

jorisvandenbossche
Copy link
Member

Small corner cases that I noticed where we are still unconditionally returning self instead of a shallow copy.

@jorisvandenbossche jorisvandenbossche added this to the 2.2 milestone Dec 4, 2023
phofl
phofl approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an actual bug, correct?

@phofl phofl merged commit 7b528c9 into pandas-dev:main Dec 4, 2023
44 checks passed
@phofl
Copy link
Member

phofl commented Dec 4, 2023

thx

@jorisvandenbossche jorisvandenbossche deleted the cow-series-ellipsis branch December 4, 2023 12:58
@jorisvandenbossche
Copy link
Member Author

That was an actual bug, correct?

Yes, in the CoW mode (I left the default mode intact, although in theory that could also have returns a new object, like : does)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Bug Copy / view semantics
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jorisvandenbossche @phofl