Assort IWYU Cleanups #56295
Merged
Assort IWYU Cleanups #56295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Dec 2, 2023
|
|
||
| #pragma once | ||
|
|
||
| #define UJSON_VERSION "1.33" |
There was a problem hiding this comment.
is this documented somewhere else?
There was a problem hiding this comment.
Its not but it isn't reflective of our current state either. I assume as things were vendored / changed this sat stagnant (1.33 ujson was 10 years ago)
mroeschke
approved these changes
Dec 4, 2023
|
Thanks @WillAyd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include-what-you-use is a relatively common tool for cleaning up includes. it helps to localize includes and identify unnecessary ones
It has a few rough edges that don't make it 100% compatible with our code base, so I'm not sure we can do this in CI. But here were a few cleanups I manually gleaned from the IWYU output that I think make sense