DOC: Update release instructions #56232
Conversation
| @@ -449,9 +449,13 @@ which will be triggered when the tag is pushed. | |||
| git tag -a v1.5.0.dev0 -m "DEV: Start 1.5.0" | |||
| git push upstream main --follow-tags | |||
|
|
|||
| 3. Build the source distribution (git must be in the tag commit):: | |||
| 3. Download the source distribution and wheels from the `wheel staging area <https://anaconda.org/scientific-python-nightly-wheels/pandas>`_. | |||
| Be careful to make sure that no wheels are missing (e.g. due to failed builds). | |||
There was a problem hiding this comment.
Would be good to describe how we can tell if a build failed
There was a problem hiding this comment.
You kind of have to look manually for the individually jobs unfortunately.
I'm trying to build reporting for failed jobs here
#55903
There was a problem hiding this comment.
Gotcha, yeah let's assume that issue will address my comment here
| 5. The GitHub release will after some hours trigger an | ||
| 5. Upload wheels to PyPI:: | ||
|
|
||
| twine upload pandas/dist/pandas-<version>*.{whl,tar.gz} --skip-existing |
There was a problem hiding this comment.
Still not fond of using the pypi publish action https://github.com/pypa/gh-action-pypi-publish (by gating it behind a manual trigger)?
There was a problem hiding this comment.
I think I'm warming up to it now.
Maybe something like https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment would be helpful?
There was a problem hiding this comment.
Nice yeah I think that would work. I can also try to look into this sometime in the future
There was a problem hiding this comment.
The latest version of the GitHub action now also implements the "Trusted Publisher" model of PyPI (https://github.com/marketplace/actions/pypi-publish#trusted-publishing), avoiding creating an API token that is stored as a secret in github
Co-authored-by: Matthew Roeschke <[email protected]>
|
Thanks @lithomas1 |
| @@ -11,6 +11,7 @@ | |||
| # one by one to the dist/ directory where they would be generated. | |||
|
|
|||
| VERSION=$1 | |||
| mkdir -p $(dirname -- $0)/../dist | |||
There was a problem hiding this comment.
Sorry for the late review. Small comment, but seems like you could just do mkdir -p $DIST_DIR if you write this in the line after defining the directory, no?
There was a problem hiding this comment.
You're right, I think.
Will make a note to do this (hopefully I don't forget).
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.