Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST/CLN: Remove makeDataFrame #56210

Merged
merged 3 commits into from
Nov 28, 2023
Merged

TST/CLN: Remove makeDataFrame #56210

merged 3 commits into from
Nov 28, 2023

Conversation

mroeschke
Copy link
Member

No description provided.

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Clean labels Nov 27, 2023
@mroeschke mroeschke added this to the 2.2 milestone Nov 28, 2023
@mroeschke
Copy link
Member Author

Looks like tests are passing here so merging. Happy to follow up if needed

@mroeschke mroeschke merged commit ae6d279 into pandas-dev:main Nov 28, 2023
42 checks passed
@mroeschke mroeschke deleted the cln/makeDataFrame branch November 28, 2023 17:08
@janosh
Copy link
Contributor

janosh commented Jan 21, 2024

I quite liked makeDataFrame (except it being camel-cased). What was the reason for removal? Seems to have caused ~400 lines of boilerplate.

@mroeschke
Copy link
Member Author

This was technically a private API in the pandas namespace. Within pandas, this was a legacy API before pytest was adopted and no longer has new usages.

@janosh
Copy link
Contributor

janosh commented Jan 22, 2024

True. Maybe it could have been converted into a pytest fixture? it's easy to replace with a fixture in my own code, but I think it's useful for every package author relying on pandas to have such a utility so why not make it a public API?

@mroeschke
Copy link
Member Author

pandas API for testing involve assertions rather than data generation which can be very arbitrary. I would recommend using hypothesis' pandas DataFrame generation: https://hypothesis.readthedocs.io/en/latest/numpy.html#pandas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @janosh