CoW: Fix deprecation warning for chained assignment #56166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
changed the title
phofl
changed the title
mroeschke
added
Warnings
Oh I am looking forward to ripping out all that code ;) |
|
Yes me too, I call dips on doing that :) |
| def test_methods_iloc_getitem_item_cache(func, args, using_copy_on_write): | ||
| df = DataFrame({"a": [1, 2, 3], "b": 1}) | ||
| ser = df.iloc[:, 0] | ||
| getattr(ser, func)(*args, inplace=True) |
There was a problem hiding this comment.
This should raise a warning?
There was a problem hiding this comment.
(or is that something we haven't implemented yet)
There was a problem hiding this comment.
That should raise but we haven’t done that yet I think, but it shouldn’t raise a chained assignment warning, which is what happens on main right now
the implementation will look similar to #56168
jorisvandenbossche
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.I hate the SettingWithCopyWarning mechanism...
2 cases were fixed here:
xref #56019