DEPR: unit keyword in TimedeltaIndex #55856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Timedelta
mroeschke
reviewed
Nov 16, 2023
| @@ -64,6 +64,10 @@ class TimedeltaIndex(DatetimeTimedeltaMixin): | |||
| Optional timedelta-like data to construct index with. | |||
| unit : {'D', 'h', 'm', 's', 'ms', 'us', 'ns'}, optional | |||
| The unit of ``data``. | |||
|
|
|||
| .. deprecated:: 2.2.0 | |||
| Use ``pd.to_timedelta`` instead. | |||
There was a problem hiding this comment.
Does that mean that integer inputs are always interpreted as nanos or based on the unit in dtype? If so, would be good to explain that here
There was a problem hiding this comment.
I guess since the behavior of int inputs with unit=None doesn't change (albeit ambiguous) I suppose this is OK
mroeschke
approved these changes
Dec 1, 2023
|
Thanks @jbrockmendel |
3 tasks
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Feb 8, 2024
For comparison: pandas-dev/pandas#55856 pandas-dev/pandas#55895 pandas-dev/pandas#55499 The `errors="ignore"` parameter is the only one that is implemented so just added a test for that deprecation Authors: - Matthew Roeschke (https://github.com/mroeschke) - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #14984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #55499