Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: parametrize and xfail #55804

Merged
merged 1 commit into from
Nov 2, 2023
Merged

CI: parametrize and xfail #55804

merged 1 commit into from
Nov 2, 2023

Conversation

jbrockmendel
Copy link
Member

@lithomas1 lithomas1 mentioned this pull request Nov 2, 2023
Merged
@lithomas1 lithomas1 added the CI Continuous Integration label Nov 2, 2023
@lithomas1
Copy link
Member

Do we need this for 2.1.x?

mroeschke
mroeschke approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs a backport to 2.1.x since the potential failure might be due to upcoming 2.2 changes, but we can backport this later if needed

@mroeschke mroeschke added this to the 2.2 milestone Nov 2, 2023
@mroeschke mroeschke merged commit 0cdb37c into pandas-dev:main Nov 2, 2023
37 of 38 checks passed
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel
Copy link
Member Author

i think the relevant test was added recently so wont be in 2.1.x

@jbrockmendel jbrockmendel deleted the ci branch November 2, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lithomas1 lithomas1 lithomas1 approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @lithomas1 @mroeschke