-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List accessor #55777
List accessor #55777
Conversation
Not sure why doc string test is failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment and some mypy issues otherwise LGTM
@mroeschke I'm not really sure how to work around the CI failure, it looks like the issue is that I'm calling _pa_array in arrow accessor which is only defined in the ArrowExtensionArray, but it's also impossible for the Series to not be backed by an ArrowExtensionArray because of the call to _validate in init. I looked at the old code in StructAccessor and it was also accessing _pa_array directly, not sure how that one passed the check and this one doesn't. Would appreciate some guidance with this. EDIT: look like it passing now, but I have a number of other CI failures:
E Failed: DID NOT RAISE <class 'pytz.exceptions.AmbiguousTimeError'> Looks unrelated. |
Nice work @rohanjain101! |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.