Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fixes DataFrame.replace documentation #55762

Merged
merged 20 commits into from
Nov 3, 2023

Conversation

jpgianfaldoni
Copy link
Contributor

@jpgianfaldoni jpgianfaldoni commented Oct 30, 2023

@@ -570,8 +570,11 @@
.. deprecated:: 2.1.0
regex : bool or same types as `to_replace`, default False
Whether to interpret `to_replace` and/or `value` as regular
expressions. If this is ``True`` then `to_replace` *must* be a
string. Alternatively, this could be a regular expression or a
expressions. If this is ``True``, `value` is not ``None`` and `to_replace` is a string,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe this in the Examples section below instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mroeschke please let me know if i can do any improvements/corrections!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reference the code checks and pre-commit CI jobs for some formatting issues that may exist here

@mroeschke mroeschke added the Docs label Oct 30, 2023
Copy link
Contributor Author

@jpgianfaldoni jpgianfaldoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit.ci autofix

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment otherwise LGTM

@mroeschke mroeschke added this to the 2.2 milestone Nov 3, 2023
@mroeschke mroeschke merged commit dd7441b into pandas-dev:main Nov 3, 2023
33 of 34 checks passed
@mroeschke
Copy link
Member

Thanks @jpgianfaldoni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: DataFrame.replace() regex contract inconsistent with usage
2 participants