-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fixes DataFrame.replace documentation #55762
DOC: Fixes DataFrame.replace documentation #55762
Conversation
pandas/core/shared_docs.py
Outdated
@@ -570,8 +570,11 @@ | |||
.. deprecated:: 2.1.0 | |||
regex : bool or same types as `to_replace`, default False | |||
Whether to interpret `to_replace` and/or `value` as regular | |||
expressions. If this is ``True`` then `to_replace` *must* be a | |||
string. Alternatively, this could be a regular expression or a | |||
expressions. If this is ``True``, `value` is not ``None`` and `to_replace` is a string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you describe this in the Example
s section below instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mroeschke please let me know if i can do any improvements/corrections!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reference the code checks and pre-commit CI jobs for some formatting issues that may exist here
…ni/pandas into quickfix/fix-to-replace-docs
…ni/pandas into quickfix/fix-to-replace-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit.ci autofix
…ni/pandas into quickfix/fix-to-replace-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment otherwise LGTM
Co-authored-by: Matthew Roeschke <[email protected]>
Co-authored-by: Matthew Roeschke <[email protected]>
Thanks @jpgianfaldoni |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.