fix segfault with tz_localize_to_utc #55726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Oct 27, 2023
mroeschke
reviewed
Oct 31, 2023
mroeschke
approved these changes
Nov 1, 2023
|
Thanks @WillAyd |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Nov 1, 2023
mroeschke
pushed a commit
that referenced
this pull request
Nov 1, 2023
…utc) (#55796) Backport PR #55726: fix segfault with tz_localize_to_utc Co-authored-by: William Ayd <[email protected]>
| delta_idx_offset = 1 | ||
| else: | ||
| delta_idx_offset = 0 | ||
| # TODO: delta_idx_offset and info.deltas are needed for zoneinfo timezones, |
There was a problem hiding this comment.
@mroeschke this comment might be relevant for the zoneinfo thing you mentioned earlier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this "fixes" the segfault in #55229 but not familiar enough to know if this is correct.
@jbrockmendel