Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/DOC: Update dtype_backend documentation and API #55692

Closed
wants to merge 1 commit into from

Conversation

jacgoldsm
Copy link

@jacgoldsm jacgoldsm commented Oct 25, 2023

  • closes ENH:  #55647
  • Corrects https://pandas.pydata.org/docs/reference/api/pandas.read_csv.html incorrectly stating that the default dtype_backend was numpy_nullable
  • Adds numpy as an option for dtype_backend, equivalent to the current default (lib.no_default). Previously it was impossible to achieve the default behavior by passing in an explicit parameter, except by passing in pandas._libs.no_default. Passing the string "numpy" is now equivalent to passing pandas._libs.no_default.

@jacgoldsm
Copy link
Author

It looks like tests specifically disallow users from passing dtype_backend=numpy. I'm curious why, and if it is intended that there be no easy way of explicitly passing in a parameter equivalent to the default. If that is the case, how should the default be labelled in the documentation? @lithomas1

Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Nov 26, 2023
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH:
2 participants