ENH: functions filter_columns and filter_rows created #55592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
requested changes
Oct 21, 2023
|
Thanks for the PR but as mentioned consensus is needed in the issue before proceeding with a PR so closing for now but happy to reopen if there's agreement to move forward here |
|
Ok, I'll be checking from time to time to see if a consensus has been reached, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Basically those 2 functions do the same as filter() in pandas/core/generic.py, but separated to deal with either columns or rows. Also hopefully it's easier without the need to specify the 'axis' and with the 'items' variable being replaced by 'colnames' and 'rownames'.
Is this close to what you expected @speed650? Your idea to have a list of boolean expressions (Filter_Rows( [ ('name'==bob), ( 'age' > 20) ])) be accepted by the functions sounded great, but I couldn't figure out how to do it without making them hard to use, defeating the purpose I suppose.