-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: Series constructor fastpath keyword #55466
Conversation
@@ -374,8 +374,18 @@ def __init__( | |||
dtype: Dtype | None = None, | |||
name=None, | |||
copy: bool | None = None, | |||
fastpath: bool = False, | |||
fastpath: bool | lib.NoDefault = lib.no_default, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need/have an alternative for the fastpath
constructor internally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we now use _constructor_from_mgr
Thanks @jbrockmendel |
This patch may have induced a performance regression. If it was a necessary behavior change, this may have been expected and everything is okay. Please check the links below. If any ASVs are parameterized, the combinations of parameters that a regression has been detected appear as subbullets. Subsequent benchmarks may have skipped some commits. See the link below to see which commits are between the two benchmark runs where the regression was identified. |
Is there an alternative for avoiding name validation now that fastpath is gone? I think this might be what's causing the regressions. |
set |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.