Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Series constructor fastpath keyword #55466

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added Deprecate Functionality to remove in pandas Series Series data structure labels Oct 10, 2023
@@ -374,8 +374,18 @@ def __init__(
dtype: Dtype | None = None,
name=None,
copy: bool | None = None,
fastpath: bool = False,
fastpath: bool | lib.NoDefault = lib.no_default,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need/have an alternative for the fastpath constructor internally?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we now use _constructor_from_mgr

@mroeschke mroeschke added this to the 2.2 milestone Oct 10, 2023
@mroeschke mroeschke merged commit 66a54a3 into pandas-dev:main Oct 10, 2023
41 checks passed
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@rhshadrach
Copy link
Member

This patch may have induced a performance regression. If it was a necessary behavior change, this may have been expected and everything is okay.

Please check the links below. If any ASVs are parameterized, the combinations of parameters that a regression has been detected appear as subbullets.

Subsequent benchmarks may have skipped some commits. See the link below to see which commits are between the two benchmark runs where the regression was identified.

e22bfb3...66a54a3

@lithomas1
Copy link
Member

@jbrockmendel

Is there an alternative for avoiding name validation now that fastpath is gone? I think this might be what's causing the regressions.

@jbrockmendel
Copy link
Member Author

set result._name = name instead of passing it to the constructor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Series Series data structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants