-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: there is no year 0 #55462
Comments
I'd like to try and fix this bug, if I could get the issue assigned to me |
I'd advise against working on this until there is consensus on how to address the issue. |
FWIW, Arrow has the same behaviour as numpy:
|
Quoting the linked wiki page:
So this mentions that the "the international standard date system, ISO 8601" uses a year zero. And in the end, one could also say that what we see in the output above is an ISO8601 formatted timestamp? |
take |
@Kman303 as @jbrockmendel mentioned above, there is not yet a clear resolution about what exactly needs to be done |
I like Joris's current-behavior-is-fine approach. |
As already commented by @jorisvandenbossche current behaviour is expected. Numpy docs 1 clarify
It seems to me that it would be safe to simply make a reference in the pandas docs to the numpy ones. Footnotes |
We document in a few places that we are using the Proleptic Gregorian calendar which does not have a year 0. The year before 1AD is 1BC in this calendar.
np.datetime64 objects have the same behavior (cc @sberg)
Expected Behavior
Refuse to parse year 0, create a Timestamp with year=0, subtraction skips year 0.
Or document the current behavior.
The text was updated successfully, but these errors were encountered: