Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: idxmax raising for arrow strings #55384

Merged
merged 3 commits into from
Oct 15, 2023
Merged

Conversation

phofl
Copy link
Member

@phofl phofl commented Oct 3, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl added this to the 2.1.2 milestone Oct 3, 2023
@mroeschke mroeschke added Strings String extension data type and string data Arrow pyarrow functionality labels Oct 3, 2023
@lithomas1
Copy link
Member

Does this need a whatsnew?

@phofl
Copy link
Member Author

phofl commented Oct 9, 2023

No there was another PR that covers this as well

@phofl
Copy link
Member Author

phofl commented Oct 13, 2023

going to merge this soon If no objections

@phofl phofl merged commit 68e3c4b into pandas-dev:main Oct 15, 2023
33 checks passed
@phofl phofl deleted the idxmax_string branch October 15, 2023 13:39
@lumberbot-app
Copy link

lumberbot-app bot commented Oct 15, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.1.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 68e3c4b2f855e6e9a8469aeca6eb73ae60327160
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #55384: BUG: idxmax raising for arrow strings'
  1. Push to a named branch:
git push YOURFORK 2.1.x:auto-backport-of-pr-55384-on-2.1.x
  1. Create a PR against branch 2.1.x, I would have named this PR:

"Backport PR #55384 on branch 2.1.x (BUG: idxmax raising for arrow strings)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

phofl added a commit to phofl/pandas that referenced this pull request Oct 15, 2023
phofl added a commit that referenced this pull request Oct 15, 2023
…ings) (#55531)

BUG: idxmax raising for arrow strings (#55384)

(cherry picked from commit 68e3c4b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants