Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Index.insert dtype-inference #55257

Merged
merged 9 commits into from
Dec 8, 2023

Conversation

jbrockmendel
Copy link
Member

Doesn't have a "do X to avoid this warning, not sure if this merits future option or temporary keyword.

@mroeschke mroeschke added the Deprecate Functionality to remove in pandas label Sep 25, 2023
@jbrockmendel
Copy link
Member Author

Its kind of annoying that this warning gets issued (the PR currently suppress it) in frame_or_series[new_key] = val. any preferences on whether to warn there?

@jbrockmendel jbrockmendel changed the title DEPR: Index.insert performing inference DEPR: Index.insert dtype-inference Oct 25, 2023
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Nov 28, 2023
@jbrockmendel
Copy link
Member Author

@phofl thoughts on doing this? i think there was some vague similarity to some of what you were working on. main open question here is whether to continue suppressing warnings on setitem-with-expansion

@phofl phofl removed the Stale label Dec 8, 2023
@phofl phofl added this to the 2.2 milestone Dec 8, 2023
@phofl phofl merged commit 124b671 into pandas-dev:main Dec 8, 2023
44 checks passed
@phofl
Copy link
Member

phofl commented Dec 8, 2023

thx @jbrockmendel

@jbrockmendel
Copy link
Member Author

Glad to get movement here, but i was hoping for some discussion of whether suppressing the warning in setitem-with-expansion was the way to go

@jbrockmendel jbrockmendel deleted the depr-index-insert branch December 9, 2023 16:14
@phofl
Copy link
Member

phofl commented Dec 9, 2023

I wouldn’t want to warn there, I don’t think that anyone cares about inference there and getting rid of it is a pain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: Index.insert too much dtype inference
3 participants