Better support for UserDict on constructor #55109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Sep 12, 2023
|
Well observed, @marcelotrevisani - Mapping is better here |
|
@mroeschke is this good to go? :-) |
Co-authored-by: Marcelo Duarte Trevisani <[email protected]>
|
@datapythonista |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
mroeschke
reviewed
Oct 16, 2023
| @@ -29,7 +29,7 @@ enhancement2 | |||
| Other enhancements | |||
| ^^^^^^^^^^^^^^^^^^ | |||
| - DataFrame.apply now allows the usage of numba (via ``engine="numba"``) to JIT compile the passed function, allowing for potential speedups (:issue:`54666`) | |||
| - | |||
| - It is now possible to pass an object that either directly inherits from ``abc.Mapping`` or has it in its inheritance chain to initialize a DataFrame. The expected behaviour is the same as if you pass a ``dict`` object. (:issue:`55109`) | |||
There was a problem hiding this comment.
Suggested change
| - It is now possible to pass an object that either directly inherits from ``abc.Mapping`` or has it in its inheritance chain to initialize a DataFrame. The expected behaviour is the same as if you pass a ``dict`` object. (:issue:`55109`) | |
| - :class:`DataFrame` now accepts ``data`` that are ``abc.Mapping`` subclasses. (:issue:`55109`) |
mroeschke
reviewed
Oct 16, 2023
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that if I create my DataFrame passing a dictionary which is a custom one of a subclass of
collections.UserDictthen we have incompatible behaviour with the one if I pass a builtindict.The idea is that the
UserDictshould have the same type interface as thedictand used for custom behaviour, instead of subclassing direct fromdict.This PR attempts to fix that incompatibility issue.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.